Okay, committed to trunk...

http://trac.mapnik.org/changeset/1124

The changeset includes some basic tests, and also modifies some of the existing tests to use 'paths_from_xml="false"' in order to (show an example of how to) maintain the previous behavior.

In addition I've also added some tests that highlight the usages of the undocumented <Datasource> and <FileSource> XML features:

(I had no idea these existed until mucking around with load_map.cpp)

https://trac.mapnik.org/browser/trunk/tests/data/good_maps/datasource.xml
https://trac.mapnik.org/browser/trunk/tests/data/good_maps/filesource.xml

These features were added in http://trac.mapnik.org/changeset/574

These features *should* work the same, whereby if relative paths are used, their base path will be interpreted as relative to the XML file.

Cheers,

Dane


On Apr 28, 2009, at 11:54 AM, Dane Springmeyer wrote:

Great, sound good.

Seems like +3 so far based on ticket comments.

I'll apply then when I have a moment unless I hear from others.

Dane


On Apr 28, 2009, at 11:50 AM, kRAkEn/gORe wrote:

oops sorry i oversee that, i though it was by default off :)
no it is ok, i like the new addition !

p.s. when you are online i have some things to ask you

cheers !


On Tue, Apr 28, 2009 at 6:50 PM, Dane Springmeyer
<[email protected]> wrote:
Hi Lucio,

Thanks for the feedback.

So you are +1 as long as it is made the default behavior?

I added the property in the xml ONLY to allow switching back to the
behavior
we have now.

Does that sound okay?

Dane



On Apr 28, 2009, at 9:13 AM, kRAkEn/gORe wrote:

Hi list,
i find it perfect, cause most of the time you will end having your
xml
mapfile besides your shape files, so you can move everything safely
(and kill those absolute paths that are killing the apps everytime
you
move around things).

+1 for applying this directly, BUT should be the default behaviour
and
definately not use a property in the XML for enabling it !

cheers,

Lucio


On Tue, Apr 28, 2009 at 7:45 AM, Dane Springmeyer <[email protected]

wrote:

Dev,

Anyone use relative paths in their XML mapfiles?

I personally would use them more frequently if the relative paths
found in the XML were interpreted as relative to the location of
the
XML file itself, rather than the script location actually calling
load_map().

So, I've proposed a fix to make this possible, and to change the
default behavior:

http://trac.mapnik.org/ticket/326

I'd like your feedback before applying to trunk in case I'm
overlooking anything.

Thanks,
Dane




_______________________________________________
Mapnik-devel mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/mapnik-devel




_______________________________________________
Mapnik-devel mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/mapnik-devel

_______________________________________________
Mapnik-devel mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/mapnik-devel

Reply via email to