[ 
https://issues.apache.org/jira/browse/MAPREDUCE-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12729348#action_12729348
 ] 

Philip Zeyliger commented on MAPREDUCE-711:
-------------------------------------------

+1 to MAPREDUCE-711-20090709-common.txt and 
MAPREDUCE-711-20090709-mapreduce.1.txt .

Owen, it would be easier (not massively so, of course), if we checked in the 
patches here (just the move), then did MAPREDUCE-476, then moved things into a 
separate package afterwards.  If you'd prefer to do the move immediately, no 
problem: a little sed will fix the patches right up.

We could name the package org.apache.hadoop.mapreduce.distributedcache, since 
filecache is a name not used anywhere else.  I'd like to (see MAPREDUCE-476) 
separate out the public interface of the distributed cache (which is merely 
setting, at job configuration time, and getting, at job runtime) from the 
internal implementation.  I think the way to do this is to have 
JobContext.getDistributedCacheData(), which encapsulates what got cached, and 
some setters as well.  The getters may be a bit futile since the configuration 
values used are probably part of the public interface, and people may be 
querying them directly.  But that's a separate task.

I'm going to go, right now, regenerate the patches for MAPREDUCE-476 assuming 
these patches go in.

> Move Distributed Cache from Common to Map/Reduce
> ------------------------------------------------
>
>                 Key: MAPREDUCE-711
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-711
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Owen O'Malley
>            Assignee: Vinod K V
>         Attachments: MAPREDUCE-711-20090709-common.txt, 
> MAPREDUCE-711-20090709-mapreduce.1.txt, MAPREDUCE-711-20090709-mapreduce.txt
>
>
> Distributed Cache logically belongs as part of map/reduce and not Common.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to