[
https://issues.apache.org/jira/browse/MAPREDUCE-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12731915#action_12731915
]
Vinod K V commented on MAPREDUCE-711:
-------------------------------------
I have run the mapred tests, all of them passed (!, surprise, surprise).
Ran ant-test also. Results:
{quote}
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 8 new or
modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] -1 findbugs. The patch appears to introduce 1 new Findbugs
warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the
total number of release audit warnings.
{quote}
The findBugs warning is unavoidable.
{quote}
<a href="#NM_SAME_SIMPLE_NAME_AS_SUPERCLASS">Bug type
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS (click for details)</a>
<br/>In class org.apache.hadoop.filecache.DistributedCache<br/>In class
org.apache.hadoop.mapreduce.filecache.DistributedCache<br/>At
DistributedCache.java:[line 29]</p>
This class has a simple name that is identical to that of its superclass, except
that its superclass is in a different package (e.g., <code>alpha.Foo</code>
extends <code>beta.Foo</code>).
This can be exceptionally confusing, create lots of situations in which you
have to look at import statements
to resolve references and creates many
opportunities to accidently define methods that do not override methods in
their superclasses
{quote}
> Move Distributed Cache from Common to Map/Reduce
> ------------------------------------------------
>
> Key: MAPREDUCE-711
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-711
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Owen O'Malley
> Assignee: Vinod K V
> Attachments: MAPREDUCE-711-20090709-common.txt,
> MAPREDUCE-711-20090709-mapreduce.1.txt, MAPREDUCE-711-20090709-mapreduce.txt,
> MAPREDUCE-711-20090710.txt
>
>
> Distributed Cache logically belongs as part of map/reduce and not Common.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
