[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786882#action_12786882
 ] 

Vinod K V commented on MAPREDUCE-1201:
--------------------------------------

The patch looks good overall. Only minor comments will improve maintainability:
 - Rename JIFFY_LENGTH to JIFFY_LENGTH_IN_MILLIs?
 - Tree-dump
   -- Change UTIME to USER_MOD_TIME and STIME to SYSTEM_TIME ?
   -- Change the tree-dump header to include the units, i.e. "UTIME(MILLIS) 
STIME(MILLIS)"

> Make ProcfsBasedProcessTree collect CPU usage information
> ---------------------------------------------------------
>
>                 Key: MAPREDUCE-1201
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1201
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>    Affects Versions: 0.22.0
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>             Fix For: 0.22.0
>
>         Attachments: MAPREDUCE-1201-v2.patch, MAPREDUCE-1201.patch
>
>
> This information can be reported back to jobtracker to help profiling jobs 
> and scheduling tasks.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to