[
https://issues.apache.org/jira/browse/MAPREDUCE-1376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12800993#action_12800993
]
Hong Tang commented on MAPREDUCE-1376:
--------------------------------------
Patch looks good mostly. A few comments:
- Please open a jira to enhance rumen to extract UGI mapping information from
job traces.
- There is no API documentation of the interface methods in UserResolver.
- There seems to be a typo in UserResolver javadoc "Maps users to a set of
users on the test cluster." => "Maps users to a set of groups on the test
cluster."
- The interface of UserResolver.setTargetUsers() requires the userspec to be
stored in a file. How about changing it to
"setTargetUsers(List<UserGroupInformation>, Configuration conf)"? Also
currently EchoUserResolver/SubmitterUserResolver ignores this info, maybe we
can have the method to return a boolean to indicate whether the method call
takes effect or not? This would also require UserResolver.parseUserList moved
to GridMix.run().
- Newly added conf parameters are not updated in GridMix.printUsage() method.
- Any reason we split GridMix.run() to GridMix.run() and GridMix.start() now?
> Support for varied user submission in Gridmix
> ---------------------------------------------
>
> Key: MAPREDUCE-1376
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1376
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: contrib/gridmix
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Attachments: M1376-0.patch, M1376-1.patch
>
>
> Gridmix currently submits all synthetic jobs as the client user. It should be
> possible to map users in the trace to a set of users appropriate for the
> target cluster.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
