[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803220#action_12803220
 ] 

Hong Tang commented on MAPREDUCE-1376:
--------------------------------------

The added set of publicly visible configuration parameters, such as 
GRIDMIX_USR_RSV, are still not documented in printUsage() method.

bq. How/whether it builds a user list from that resource may be specific to the 
UserResolver implementation.

I'd suggest we decouple the logic of obtaining the list of target users from 
resolving source users to target users. It also seems reasonable to me to only 
support getting the list of target users from a file with a well-known format 
for now. We can extend it later if we want to support specifying users through 
command line or from LDAP, etc (as you can see, some of such extensions may not 
be easily doable through a URI-based interface).

bq. The driver would probably ignore that feedback, wouldn't it?

There could be a couple of possible enhancements based such feedback: One is to 
issue an INFO/WARN log by Gridmix3 in the case when the resolver ignores the 
targeted user list. The other is to do extra runtime check that a user returned 
by the resolver is actually valid before submitting the job to the job tracker 
for plugins that do not honor the targeted set of users. We do not have to 
implement such enhancements in this patch, but I think it is a good idea to 
make the interface not hide any capability of a particular resolver.

Other than these, the new patch addressed the remaining of my previous 
comments. Thanks.

> Support for varied user submission in Gridmix
> ---------------------------------------------
>
>                 Key: MAPREDUCE-1376
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1376
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: contrib/gridmix
>            Reporter: Chris Douglas
>            Assignee: Chris Douglas
>         Attachments: M1376-0.patch, M1376-1.patch, M1376-2.patch
>
>
> Gridmix currently submits all synthetic jobs as the client user. It should be 
> possible to map users in the trace to a set of users appropriate for the 
> target cluster.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to