[
https://issues.apache.org/jira/browse/MAPREDUCE-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12852006#action_12852006
]
Konstantin Boudnik commented on MAPREDUCE-1654:
-----------------------------------------------
Please fix the following:
- mix of JUnit v3 and v4 APIs
{noformat}
+import junit.framework.Assert;
...
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.Test;
{noformat}
- inconstant use of curve brackets '{':
{noformat}
+ public static class MapperFail extends Mapper<LongWritable,Text,Text,Text>
+ {
...
+ public static class CommitterWithFailCleanup extends FileOutputCommitter {
{noformat}
- public methods and classes should have proper JavaDoc
- mix of incorrect and correct indentations:
{noformat}
+ public void reduce(Text key, Iterator<Text> values,
+ Context context) throws IOException,InterruptedException {
...
+ public void map(LongWritable key, Text value, Context context)
+ throws IOException,InterruptedException {
{noformat}
- inconsistent use of blank lines:
{noformat}
+ throws IOException,InterruptedException {
+
+ }
...
+ throw new IOException();
+ }
{noformat}
latter is acceptable; the former isn't.
- good to have whitespaces after commas in the list of parameters i.e. a bad
taste
{{+
JobKillCommitter.MapperPass.class,JobKillCommitter.ReducerFail.class);}}
> Automate the job killing system test case.
> -------------------------------------------
>
> Key: MAPREDUCE-1654
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1654
> Project: Hadoop Map/Reduce
> Issue Type: New Feature
> Components: test
> Affects Versions: 0.20.3
> Environment: Herriot system test case development env.
> Reporter: Balaji Rajagopalan
> Attachments: patch_1654.txt
>
> Original Estimate: 0.27h
> Remaining Estimate: 0.27h
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
