[
https://issues.apache.org/jira/browse/MAPREDUCE-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855922#action_12855922
]
Iyappan Srinivasan commented on MAPREDUCE-1654:
-----------------------------------------------
Hi Balaji,
Patch looks good.
Some coments:
1) The LogFactory.getLog(TestCluster.class) should point to the correct class.
2) The name of the "before" and "after" methods can be more meaningful like
"setup" and "cleanup"
3) All Assert statements should have comments, so taht it gives out a
meaningful statement when taht failure hapens.
4) Both BeforeClass method and AfterClass method should delete both the input
Directoy and output Directory. Reason being for BeforeClass, some other
testcase might have already created this directory, so when this testcase
starts, it should delete it, if it exists, as a precaution. Reason for
afterClass is the testcase might fail at any point in the testExecution, so
when it exits, even in failure, it should delete those directories and then
exit.
5) Comment explaing the TestJobKill.java funtionality can be little more clear
"The test checks after job failure that a file called "success"
does not exist in the output directory"
6) Comment explaining the "JobKillCommitter". Some of htem are like "The class
is used provides". IT can be changed to "This class provides"
> Automate the job killing system test case.
> -------------------------------------------
>
> Key: MAPREDUCE-1654
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1654
> Project: Hadoop Map/Reduce
> Issue Type: Test
> Components: test
> Environment: Herriot system test case development env.
> Reporter: Balaji Rajagopalan
> Assignee: Balaji Rajagopalan
> Attachments: patch_1654.txt, patch_1654.txt, patch_1654.txt,
> patch_1654_1.txt, patch_1654_2.txt,
> TEST-org.apache.hadoop.mapred.TestJobKill.txt
>
> Original Estimate: 0.27h
> Remaining Estimate: 0.27h
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
