[
https://issues.apache.org/jira/browse/MAPREDUCE-1276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857263#action_12857263
]
Amareshwari Sriramadasu commented on MAPREDUCE-1276:
----------------------------------------------------
Test output from hudson's console :
[exec]
[exec] -1 overall. Here are the results of testing the latest attachment
[exec]
http://issues.apache.org/jira/secure/attachment/12441703/patch-1276.txt
[exec] against trunk revision 933441.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new
or modified tests.
[exec] Please justify why no new tests are needed
for this patch.
[exec] Also please list what manual steps were
performed to verify this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the
total number of release audit warnings.
[exec]
[exec] +1 core tests. The patch passed core unit tests.
[exec]
[exec] -1 contrib tests. The patch failed contrib unit tests.
[exec]
[exec] Test results:
http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/108/testReport/
[exec] Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/108/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
[exec] Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/108/artifact/trunk/build/test/checkstyle-errors.html
[exec] Console output:
http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/108/console
bq. -1 contrib tests
Contrib test failures are because NoClassDefFoundError (MAPREDUCE-1275).
bq. -1 tests included.
It is difficult to write a Junit test for simulating Read or Connect Timeout in
shuffle. I created MAPREDUCE-1708 to add a fault injection test.
I manually tested the patch by adding sleep in
TaskTracker.MapOutputServlet.sendMapFile for one of the attempts. Verified the
attempt gets failed because of "Too many fetch failures"; re-executes on some
other machine; and the job succeeds.
> Shuffle connection logic needs correction
> ------------------------------------------
>
> Key: MAPREDUCE-1276
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1276
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: task
> Affects Versions: 0.21.0
> Reporter: Jothi Padmanabhan
> Assignee: Amareshwari Sriramadasu
> Priority: Blocker
> Fix For: 0.21.0
>
> Attachments: patch-1276.txt
>
>
> While looking at the code with Amareshwari, we realized that
> {{Fetcher#copyFromHost}} marks connection as successful when
> {{url.openConnection}} returns. This is wrong. Connection is done inside
> implicitly inside {{getInputStream}}; we need to split {{getInputStream}}
> into {{connect}} and {{getInputStream}} to handle the connection and read
> time out strategies correctly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
