[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12865013#action_12865013
 ] 

Amareshwari Sriramadasu commented on MAPREDUCE-1276:
----------------------------------------------------

bq. -1 core tests.
Test failure TestSetupAndCleanupFailure is not related to the patch. It is 
because of ZipException.
The same test passed on my machine.

> Shuffle connection logic needs correction 
> ------------------------------------------
>
>                 Key: MAPREDUCE-1276
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1276
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: task
>    Affects Versions: 0.21.0
>            Reporter: Jothi Padmanabhan
>            Assignee: Amareshwari Sriramadasu
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: patch-1276-1.txt, patch-1276-2.txt, patch-1276.txt
>
>
> While looking at the code with Amareshwari, we realized that  
> {{Fetcher#copyFromHost}} marks connection as successful when 
> {{url.openConnection}} returns. This is wrong. Connection is done inside 
> implicitly inside {{getInputStream}}; we need to split {{getInputStream}} 
> into {{connect}} and {{getInputStream}} to handle the connection and read 
> time out strategies correctly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to