[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12876148#action_12876148
 ] 

Amareshwari Sriramadasu commented on MAPREDUCE-1813:
----------------------------------------------------

Some comments on the patch:
1. The current test is not regression test. The test added in earlier patch 
with empty input, should still be there.
2. Starting up and shutting down MiniMRCluster for every testcase will just 
increase the test time. Can you run testStreamingMapStatus and 
testStreamingReduceStatus with single setup of MiniMRCluster.
3. Minor : Can you rename mapAttemptID in method validateTaskStderr to just 
attemptID ?

> NPE in PipeMapred.MRErrorThread
> -------------------------------
>
>                 Key: MAPREDUCE-1813
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1813
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: contrib/streaming
>    Affects Versions: 0.20.1
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Ravi Gummadi
>             Fix For: 0.20.3
>
>         Attachments: 1813.patch, 1813.v1.patch
>
>
> Some reduce tasks fail with following NPE
> java.lang.RuntimeException: java.lang.NullPointerException
>         at 
> org.apache.hadoop.streaming.PipeMapRed.waitOutputThreads(PipeMapRed.java:325)
>         at 
> org.apache.hadoop.streaming.PipeMapRed.mapRedFinished(PipeMapRed.java:540)
>         at org.apache.hadoop.streaming.PipeReducer.close(PipeReducer.java:137)
>         at 
> org.apache.hadoop.mapred.ReduceTask.runOldReducer(ReduceTask.java:474)
>         at org.apache.hadoop.mapred.ReduceTask.run(ReduceTask.java:412)
>         at org.apache.hadoop.mapred.Child.main(Child.java:159)
> Caused by: java.lang.NullPointerException
>        at 
> org.apache.hadoop.streaming.PipeMapRed$MRErrorThread.setStatus(PipeMapRed.java:517)
>         at 
> org.apache.hadoop.streaming.PipeMapRed$MRErrorThread.run(PipeMapRed.java:449)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to