[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925173#action_12925173
 ] 

Doug Cutting commented on MAPREDUCE-1410:
-----------------------------------------

I just ran test-patch by hand on this.

{code}
+1 overall.  

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 9 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 system tests framework.  The patch passed system tests framework compile.
{code}

> Task-Cleanup attempt cannot be given KillTaskAction if the main attempt is 
> killed with a KillTaskAction
> -------------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1410
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1410
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: jobtracker
>    Affects Versions: 0.20.1
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>             Fix For: 0.22.0
>
>         Attachments: MAPREDUCE-1410.patch, patch-1410.txt
>
>
> If the main attempt is killed with a KillTaskAction and is added to 
> tasksReportedClosed, then the cleanup-attempt for the task (with same id) can 
> not be given a KillTaskAction, since tasksReportedClosed already contains the 
> attemptID.  
> The attemptID should be removed from  tasksReportedClosed in 
> incompleteSubTask() method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to