[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12990381#comment-12990381
 ] 

Konstantin Shvachko commented on MAPREDUCE-1410:
------------------------------------------------

> -1 system test framework.

You probably have some problems with gcc there. I don't think it is blocking as 
there are no changes to native code, and this target succeeded on Doug's run 
before.

> -1 release audit.

Don't see any new files are introduced in the patch. We probably need to add 
some exclusions, which were omitted in previous commits.

Other than that looks good to me.
How are the tests doing with this patch?

> Task-Cleanup attempt cannot be given KillTaskAction if the main attempt is 
> killed with a KillTaskAction
> -------------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1410
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1410
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: jobtracker
>    Affects Versions: 0.20.1
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>         Attachments: MAPREDUCE-1410.patch, MAPREDUCE-1410.patch, 
> patch-1410.txt
>
>
> If the main attempt is killed with a KillTaskAction and is added to 
> tasksReportedClosed, then the cleanup-attempt for the task (with same id) can 
> not be given a KillTaskAction, since tasksReportedClosed already contains the 
> attemptID.  
> The attemptID should be removed from  tasksReportedClosed in 
> incompleteSubTask() method.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to