[
https://issues.apache.org/jira/browse/MAPREDUCE-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Joseph Evans updated MAPREDUCE-2573:
-------------------------------------------
Attachment: MR-2573-mr-trunk-V1.patch
OK I was wrong after looking at the changed I did touch that part of the code
with the intention of making it static, but I guess I never did it. This patch
fixes that. There are no new tests for it, as it is a very simple change.
> New findbugs warning after MAPREDUCE-2494
> -----------------------------------------
>
> Key: MAPREDUCE-2573
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2573
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Todd Lipcon
> Assignee: Robert Joseph Evans
> Attachments: MR-2573-mr-trunk-V1.patch
>
>
> MAPREDUCE-2494 introduced the following findbugs warning in trunk:
> TrackerDistributedCacheManager.java:739, SIC_INNER_SHOULD_BE_STATIC,
> Priority: Low
> Should
> org.apache.hadoop.mapreduce.filecache.TrackerDistributedCacheManager$CacheDir
> be a _static_ inner class?
> This class is an inner class, but does not use its embedded reference to the
> object which created it. This reference makes the instances of the class
> larger, and may keep the reference to the creator object alive longer than
> necessary. If possible, the class should be made static.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
