[ 
https://issues.apache.org/jira/browse/MAPREDUCE-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046621#comment-13046621
 ] 

Robert Joseph Evans commented on MAPREDUCE-2573:
------------------------------------------------

I really don't know what is happening with the contrib and core tests.  I only 
changed a single line to make an inner class static that should be static.  
Also the precommit 363 build, that Jenkins is pointing us to failed, so it must 
not be the correct build. 

> New findbugs warning after MAPREDUCE-2494
> -----------------------------------------
>
>                 Key: MAPREDUCE-2573
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2573
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Todd Lipcon
>            Assignee: Robert Joseph Evans
>         Attachments: MR-2573-mr-trunk-V1.patch
>
>
> MAPREDUCE-2494 introduced the following findbugs warning in trunk:
> TrackerDistributedCacheManager.java:739, SIC_INNER_SHOULD_BE_STATIC, 
> Priority: Low
> Should 
> org.apache.hadoop.mapreduce.filecache.TrackerDistributedCacheManager$CacheDir 
> be a _static_ inner class?
> This class is an inner class, but does not use its embedded reference to the 
> object which created it.  This reference makes the instances of the class 
> larger, and may keep the reference to the creator object alive longer than 
> necessary.  If possible, the class should be made static.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to