[
https://issues.apache.org/jira/browse/MAPREDUCE-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132860#comment-13132860
]
Vinod Kumar Vavilapalli commented on MAPREDUCE-2775:
----------------------------------------------------
This needs a little bit more of effort: Hopefully the final set of comments:
- Shall we rename {{NodeAction.DECOMMISSION}} to {{SHUTDOWN}}}?
- Need to send a {{SHUTDOWN}} command to the nodes even if it is invalid at
the RM at the time of registration. This is a very common case, we exclude the
node even before we start the cluster.
- Please also add a test for the above.
- If the node is not valid, the correct component to send a
{{RMNodeEventType.DECOMMISSION}} event to {{RMNode}} is {{NodeListManager}}. We
can move this code out of {{ResourceTrackerService}} into
{{NodeListManager.refreshNodes()}} - sending events to all nodes that get
decomissioned during {{refreshNodes()}}. This will also ensure that the
decomissioned-node-count gets incremented immediately instead of waiting for
all the nodes to reach RM. Your tests in {{TestResourceTrackerService}} also
simplify a bit.
- {{TestNodeStatusUpdater}}: The two second sleeps are error prone. I think it
should simply wait till heartBeatID becomes more than 3 or a timeout
- Similarly in {{TestNMExpiry}}, you should spin around till lost-nodes' count
becomes two or a timeout happens.
- {{TestResourceTrackerService}} is good work!
-- {{checkDecommissionedNMCount()}}: Again spin till the correct count or a
timeout occurs.
> [MR-279] Decommissioned node does not shutdown
> ----------------------------------------------
>
> Key: MAPREDUCE-2775
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2775
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.23.0
> Reporter: Ramya Sunil
> Assignee: Devaraj K
> Priority: Blocker
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2775-1.patch, MAPREDUCE-2775-2.patch,
> MAPREDUCE-2775-3.patch, MAPREDUCE-2775-4.patch, MAPREDUCE-2775.patch,
> MAPREDUCE-2775.patch
>
>
> A Nodemanager which is decommissioned by an admin via refreshnodes does not
> automatically shutdown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
