[ https://issues.apache.org/jira/browse/MAPREDUCE-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132893#comment-13132893 ]
Arun C Murthy commented on MAPREDUCE-2775: ------------------------------------------ bq. If the node is not valid, the correct component to send a RMNodeEventType.DECOMMISSION event to RMNode is NodeListManager. We can move this code out of ResourceTrackerService into NodeListManager.refreshNodes() - sending events to all nodes that get decomissioned during refreshNodes(). This will also ensure that the decomissioned-node-count gets incremented immediately instead of waiting for all the nodes to reach RM. Your tests in TestResourceTrackerService also simplify a bit. That seems like an involved change... the current fix is simpler? i.e. check each h/b and send it to the NM only when it sends a h/b ? bq. TestNodeStatusUpdater: The two second sleeps are error prone. I think it should simply wait till heartBeatID becomes more than 3 or a timeout +1, please fix this. Thread.sleep is usually indicative of something wrong. > [MR-279] Decommissioned node does not shutdown > ---------------------------------------------- > > Key: MAPREDUCE-2775 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-2775 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv2 > Affects Versions: 0.23.0 > Reporter: Ramya Sunil > Assignee: Devaraj K > Priority: Blocker > Fix For: 0.23.0 > > Attachments: MAPREDUCE-2775-1.patch, MAPREDUCE-2775-2.patch, > MAPREDUCE-2775-3.patch, MAPREDUCE-2775-4.patch, MAPREDUCE-2775.patch, > MAPREDUCE-2775.patch > > > A Nodemanager which is decommissioned by an admin via refreshnodes does not > automatically shutdown. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira