[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205701#comment-13205701
 ] 

Sanjay Radia commented on MAPREDUCE-3825:
-----------------------------------------

Dryn, Read your doc.
The solution you are proposing (let me call it solution 3) seems to needs 3 
APIs: 
a) FileSystem#getDelegationToken(renewer) - Same as Solution 1's method.
b) FileSystem#getDelegationToken(renewer, credentials)
c) FileSystem#getFIleSystems() - same as Solution 1's getEmbededFileSystems().

I can't figure out if and how you are using (b)  
FileSystem#getDelegationToken(renewer, credentials).
I am arguing that solution 1 or 2 are sufficient. Your solution seems to be 
close to solution 1 and i can't figure out how and when you are using API (b)

@Dryn> but performing the elimination of dups is actually pretty simple:
*Yes yes yes* - that is what is used in solution 1. My text says "eliminates 
the duplicate file systems".
I am not saying that this code is hard to write - we are in violent agreement.

I like Solution 1. - it has clean APIs.
But solution 2 has an advantage - see my comment at [solution2Advantage | 
https://issues.apache.org/jira/browse/MAPREDUCE-3825?focusedCommentId=13205209&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13205209]

Questions for you:
A) Do you believe your solution 3 is different from solution 1. If so why do 
you need to add api (b).
B) Do you agree or disagree with the advantage of solution 2 that i commented - 
i am reluctantly beginning to agree with it after talking to the MR folks based 
on the reasons given in my comment.
                
> Need generalized multi-token filesystem support
> -----------------------------------------------
>
>                 Key: MAPREDUCE-3825
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3825
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.23.1, 0.24.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: MAPREDUCE-3825.patch, TokenCache.pdf
>
>
> This is the counterpart to HADOOP-7967.  The token cache currently tries to 
> assume a filesystem's token service key.  The assumption generally worked 
> while there was a one to one mapping of filesystem to token.  With the advent 
> of multi-token filesystems like viewfs, the token cache will try to use a 
> service key (ie. for viewfs) that will never exist (because it really gets 
> the mounted fs tokens).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to