[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205712#comment-13205712
 ] 

Daryn Sharp commented on MAPREDUCE-3825:
----------------------------------------

I tried to explain in the last paragraph of the doc the alternate patch that I 
haven't posted which is what I'd ideally like to see:
* {{TokenCache#obtainTokensForNamenodes}} does *not* use {{getFileSystems()}}, 
thus it does not flatten the filesystems
* {{TokenCache#obtainTokensForNamenodes}} does *not* use 
{{getCanonicalServiceName()}} so it longer has a cross-dep on {{FileSystem}}
* {{TokenCache#obtainTokensForNamenodes}} should only call 
{{getDelegationTokens(renewer, creds)}} on each path's filesystem
* {{FileSystem#getFileSystems}} is used internally by 
{{getDelegationTokens(renewer, creds)}}

The advantage of solution #2 is based on a misunderstanding.  Those 
requirements don't need to be met at all.  I was proposing TokenCache do that 
to reduce the unnecessary/redundant calls.
                
> Need generalized multi-token filesystem support
> -----------------------------------------------
>
>                 Key: MAPREDUCE-3825
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3825
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.23.1, 0.24.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: MAPREDUCE-3825.patch, TokenCache.pdf
>
>
> This is the counterpart to HADOOP-7967.  The token cache currently tries to 
> assume a filesystem's token service key.  The assumption generally worked 
> while there was a one to one mapping of filesystem to token.  With the advent 
> of multi-token filesystems like viewfs, the token cache will try to use a 
> service key (ie. for viewfs) that will never exist (because it really gets 
> the mounted fs tokens).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to