[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259732#comment-13259732
 ] 

Harsh J commented on MAPREDUCE-4172:
------------------------------------

Arun - Sure, I can attach a mega patch here. Would it be easy to review? I 
managed to fix all tests post my changes.

Off the 16 ones here, only a few of them are small enough to be called 1-line 
patches btw. Some patches are high KBs in size and thats why I decided to chunk 
them down to projects/modules. But in any case, I have 16 commits on my git 
repo I can squash together. Please do confirm if it will be alright, as I don't 
want it going stale :)
                
> Clean up java warnings in the hadoop-mapreduce-project sub projects
> -------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4172
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4172
>             Project: Hadoop Map/Reduce
>          Issue Type: Task
>          Components: build
>    Affects Versions: trunk
>            Reporter: Harsh J
>            Assignee: Harsh J
>
> There are lots of warnings in the hadoop-mapreduce-project presently. We can 
> clear almost all of this away:
> * Unused imports
> * Unused variables
> ** For loops that can be replaced with while instead to save an unused 
> variable
> * Unused methods
> * Deprecation warnings where an alternative can be used (Especially 
> SequenceFile reader/writer usage and MiniDFSCluster usage)
> * Deprecation warnings where an alternative isn't clear (Especially 
> MiniMRCluster usage and DistributedCache API usage where a Job object may not 
> be available)
> * Unchecked conversions
> * Raw type usage
> * (etc.)
> I'm going to open one sub-task per sub-project we have, with patches attached 
> to them.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to