[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13263565#comment-13263565
 ] 

Harsh J commented on MAPREDUCE-4172:
------------------------------------

Hi,

Is there still interest in clearing up these javac warnings? I have addressed 
all failing tests across each project (And in my tree I have them all and tests 
all still pass).

I can't maintain this for very long. The changes are very trivial in nature and 
chunked for easy review. If you feel review would be easy with a mega patch, 
I'll supply that. 

We could at least review these incrementally in the current structure. Whats 
the big deal with commits done per project anyway, when the commit does include 
proper message and only touches few points in the code without altering logic?
                
> Clean up java warnings in the hadoop-mapreduce-project sub projects
> -------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4172
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4172
>             Project: Hadoop Map/Reduce
>          Issue Type: Task
>          Components: build
>    Affects Versions: trunk
>            Reporter: Harsh J
>            Assignee: Harsh J
>
> There are lots of warnings in the hadoop-mapreduce-project presently. We can 
> clear almost all of this away:
> * Unused imports
> * Unused variables
> ** For loops that can be replaced with while instead to save an unused 
> variable
> * Unused methods
> * Deprecation warnings where an alternative can be used (Especially 
> SequenceFile reader/writer usage and MiniDFSCluster usage)
> * Deprecation warnings where an alternative isn't clear (Especially 
> MiniMRCluster usage and DistributedCache API usage where a Job object may not 
> be available)
> * Unchecked conversions
> * Raw type usage
> * (etc.)
> I'm going to open one sub-task per sub-project we have, with patches attached 
> to them.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to