[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415590#comment-13415590
 ] 

Bikas Saha commented on MAPREDUCE-4351:
---------------------------------------

Seems to me that there is some code in DefaultContainerMonitor that should move 
into a base class. E.g. no point requiring every derived class implement event 
handlers unless they want to change the handling mechanism such as a different 
threading model. Or one could consider DefaultContainerMonitor the base class 
with a complete implementation. In that case, a rename and more comments would 
be good.
                
> Make ContainersMonitor pluggable
> --------------------------------
>
>                 Key: MAPREDUCE-4351
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4351
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: mrv2, nodemanager
>            Reporter: Andrew Ferguson
>            Assignee: Andrew Ferguson
>         Attachments: MAPREDUCE-4351-v1.patch, MAPREDUCE-4351-v2.patch, 
> MAPREDUCE-4351-v3.patch, MAPREDUCE-4351-v4.patch, MAPREDUCE-4351-v4.patch, 
> MAPREDUCE-4351-v5.patch, MAPREDUCE-4351-v5.patch, MAPREDUCE-4351-v6.patch
>
>
> Make the existing ContainersManager pluggable, just as the ContainerExecutor 
> is currently. This will allow us to add container resource enforcement using 
> other techniques (such as cgroups) in an extensible fashion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to