[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415690#comment-13415690
 ] 

Andrew Ferguson commented on MAPREDUCE-4351:
--------------------------------------------

ok, that's what I thought you meant as an example, but wanted to double-check.

handle() was one of the functions I wrote differently for 
CgroupsContainersMonitor. Therefore, I wouldn't think of it as a candidate to 
move to a base class.

To me, handle() seems like the core of a ContainersMonitor -- it receives 
START_MONITORING_CONTAINER and STOP_MONITORING_CONTAINER and decides what to do.
                
> Make ContainersMonitor pluggable
> --------------------------------
>
>                 Key: MAPREDUCE-4351
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4351
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: mrv2, nodemanager
>            Reporter: Andrew Ferguson
>            Assignee: Andrew Ferguson
>         Attachments: MAPREDUCE-4351-v1.patch, MAPREDUCE-4351-v2.patch, 
> MAPREDUCE-4351-v3.patch, MAPREDUCE-4351-v4.patch, MAPREDUCE-4351-v4.patch, 
> MAPREDUCE-4351-v5.patch, MAPREDUCE-4351-v5.patch, MAPREDUCE-4351-v6.patch
>
>
> Make the existing ContainersManager pluggable, just as the ContainerExecutor 
> is currently. This will allow us to add container resource enforcement using 
> other techniques (such as cgroups) in an extensible fashion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to