[
https://issues.apache.org/jira/browse/MAPREDUCE-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13569080#comment-13569080
]
Robert Joseph Evans commented on MAPREDUCE-4905:
------------------------------------------------
Sorry about taking so long to look at this JIRA. I have a few comments.
# Some of the files need the Apache License header in them.
# Some of the indentation seems to be a bit off in PipeApplicatoinClient.java
and some of the other files too (very minor)
# I think we want to rename PipeApplicatoinRunabeClient to
PipeApplicationRunnableClient (added an 'n' and 'l' in Runnable and fixed the
spelling of Application)
# We need of fix the spelling of Application in PipeApplicatoinClient too.
# Could we fix the spelling of Reduser too Reducer
# some of the code in the tests looks like it is a copy and paste from other
parts. It would be nice if it is common, but if that is going to take a lot of
work, don't worry about it.
I would like to understand a bit better exactly what we are testing in all
cases. In the case of PipeApplicatoinRunabeClient with
TestPipeApplication#testRunner() I can see that we are doing some basic hand
shaking and security pieces, and then verifying that what was written to stdout
has some patterns in it. But there are some places (like in
PipeApplicatoinRunabeClient) we are reading and throwing away data. Or that we
read the data and write it to stdout, but never verify that it is what is
expected. It would be good to either clearly define what this is testing and
make the other stuff more common boilerplate code or to assert that the values
are correct in PipeApplicatoinRunabeClient (either directly or by writing to
stdout like is happening now.
I have not had a chance to dig into all of the tests, but it would be good to
have the other tests better clearly define what they are testing.
> test org.apache.hadoop.mapred.pipes
> -----------------------------------
>
> Key: MAPREDUCE-4905
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4905
> Project: Hadoop Map/Reduce
> Issue Type: Test
> Affects Versions: 3.0.0, 2.0.3-alpha, 0.23.6
> Reporter: Aleksey Gorshkov
> Fix For: 3.0.0, 2.0.3-alpha, 0.23.6
>
> Attachments: MAPREDUCE-4905-trunk.patch
>
>
> tests for org.apache.hadoop.mapred.pipes
> patch MAPREDUCE-4905-trunk.patch for trunk, branch-2, branch-0.23
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
