[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13571438#comment-13571438
 ] 

Robert Joseph Evans commented on MAPREDUCE-4905:
------------------------------------------------

Thanks for fixing all of my comments.  I do have one more final comment, and 
this is minor.  Inside PipeApplicationStub.java the code is sending a progress.

{code}
// progress
WritableUtils.writeVInt(dataOut, 53);
dataOut.writeFloat(5.5f);
{code}

Progress itself is intended to be between 0.0 and 1.0.  5.5, which equates to 
550% done, seems like a bit much. It would be nice to set it to 0.5 or 
something else more appropriate.
                
> test org.apache.hadoop.mapred.pipes
> -----------------------------------
>
>                 Key: MAPREDUCE-4905
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4905
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>    Affects Versions: 3.0.0, 2.0.3-alpha, 0.23.6
>            Reporter: Aleksey Gorshkov
>             Fix For: 3.0.0, 2.0.3-alpha, 0.23.6
>
>         Attachments: MAPREDUCE-4905-trunk-a.patch, MAPREDUCE-4905-trunk.patch
>
>
> tests for  org.apache.hadoop.mapred.pipes
> patch MAPREDUCE-4905-trunk.patch for trunk, branch-2, branch-0.23

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to