[ https://issues.apache.org/jira/browse/MAPREDUCE-5130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13655406#comment-13655406 ]
Vinod Kumar Vavilapalli commented on MAPREDUCE-5130: ---------------------------------------------------- bq. Filed MAPREDUCE-5236 MAPREDUCE-5236 seemed incorrect when looked in isolation. Commented there. Can you just modify that to mean that the test-case is failing? This is another general suggestion: File tickets describing the problem and then propose the solution as a comment. bq. computeNumSlotsPer* isn't used anywhere in the code. As there are no more slots in YARN, and it is not a public API, would it not make the most sense to remove it? +1, let's remove the method itself here. > Add missing job config options to mapred-default.xml > ---------------------------------------------------- > > Key: MAPREDUCE-5130 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5130 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: documentation > Affects Versions: 2.0.4-alpha > Reporter: Sandy Ryza > Assignee: Sandy Ryza > Attachments: MAPREDUCE-5130-1.patch, MAPREDUCE-5130-1.patch, > MAPREDUCE-5130-2.patch, MAPREDUCE-5130.patch > > > I came across that mapreduce.map.child.java.opts and > mapreduce.reduce.child.java.opts were missing in mapred-default.xml. I'll do > a fuller sweep to see what else is missing before posting a patch. > List so far: > mapreduce.map/reduce.child.java.opts > mapreduce.map/reduce.memory.mb > mapreduce.job.jvm.numtasks > mapreduce.input.lineinputformat.linespermap > mapreduce.task.combine.progress.records -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira