[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13659936#comment-13659936
 ] 

Sandy Ryza commented on MAPREDUCE-5130:
---------------------------------------

bq. Why remove the timeout for testJobConf()?
Sorry, careless error.  Had removed it to debug something.

Will upload a patch that leaves out mapreduce.job.jvm.numtasks for real this 
time, puts back in the comments for getMemoryForMapTask() and 
getMemoryForReduceTask(), puts back in normalizeConfigValue(), and puts back in 
a modified version of testNegativeValuesForMemoryParams().

bq. When someone gives a negative value for the vmem properties, we should just 
use the default one.
By this you mean that we should check to see whether the configured number is 
invalid and silently return the default if it is?  I haven't seen this for 
other properties.
                
> Add missing job config options to mapred-default.xml
> ----------------------------------------------------
>
>                 Key: MAPREDUCE-5130
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5130
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: documentation
>    Affects Versions: 2.0.4-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: MAPREDUCE-5130-1.patch, MAPREDUCE-5130-1.patch, 
> MAPREDUCE-5130-2.patch, MAPREDUCE-5130-3.patch, MAPREDUCE-5130.patch
>
>
> I came across that mapreduce.map.child.java.opts and 
> mapreduce.reduce.child.java.opts were missing in mapred-default.xml.  I'll do 
> a fuller sweep to see what else is missing before posting a patch.
> List so far:
> mapreduce.map/reduce.child.java.opts
> mapreduce.map/reduce.memory.mb
> mapreduce.job.jvm.numtasks
> mapreduce.input.lineinputformat.linespermap
> mapreduce.task.combine.progress.records

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to