[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13663020#comment-13663020
 ] 

Jason Lowe commented on MAPREDUCE-5261:
---------------------------------------

I noticed that test-patch dropped the ball on both MAPREDUCE-5257 and YARN-617. 
 Looking at the console output during the test build, we can clearly see that 
the build failed yet test-patch reported an overall +1.  That's Not Good, and 
we would have caught these problems on YARN-617 if it was working properly.  
Filed HADOOP-9583 to track the test-patch issue.

Took a quick look at the patch, seems OK for fixing just the test.  My main nit 
is that it would have been nice to use local variables (e.g.: host1, host2, 
host3) for the string constants rather than a blind search/replace since it 
would make the code easier on the eyes, but not something that has to be fixed. 
 Are there other tests that are going to have to register IP addresses rather 
than fake hostnames when calling rm.registerNode() to avoid a similar fate?

Also is this test failure indicating that the RM could fall over if it tries to 
create a token for a host for which it currently cannot lookup the hostname?  
It would be unfortunate if a DNS hiccup brought down the RM on a regular basis. 
 I'm wondering if there's more to fix here than just the test.
                
> TestRMContainerAllocator is exiting and failing the build
> ---------------------------------------------------------
>
>                 Key: MAPREDUCE-5261
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5261
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 2.0.5-beta
>            Reporter: Jason Lowe
>            Assignee: Omkar Vinit Joshi
>         Attachments: MAPREDUCE-5261.patch
>
>
> Recent builds are failing because TestRMContainerAllocator is exiting rather 
> than succeeding or failing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to