[
https://issues.apache.org/jira/browse/MAPREDUCE-5228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13668684#comment-13668684
]
Mayank Bansal commented on MAPREDUCE-5228:
------------------------------------------
Thanks zhijie for review.
>>>>2. depricatedCounterMap, initDepricatedMap() and getNewGroupKey() is better
>>>>to be defined in AbstractCounters
I had a offline discussion with Zhijie, Based on that it will be more
appropriate to add these methods in Counters class.
>>>> 3. Whenever FileInputFormatCounter and FileOutputFormatCounter are
>>>> referred, the mapping policy needs to be applied. Now it's only applied in
>>>> one place.
This is been called at one place only.
I was following more generic approach but based on zhijie we need to do
specific to this case so changed the code for that.
Thanks,
Mayank
> Enum Counter is removed from FileInputFormat and FileOutputFormat of both
> mapred and mapreduce
> ----------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-5228
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5228
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Reporter: Zhijie Shen
> Assignee: Mayank Bansal
> Attachments: MAPREDUCE-5228-trunk-1.patch,
> MAPREDUCE-5228-trunk-2.patch
>
>
> The enum was used by findCounter(Enum key) to find a specific counter object.
> Now it seems to be replaced by FileInputFormatCounter and
> FileOutputFormatCounter. Now the enum seems to be only used internally, but
> not sure whether it will be used externally when users extend FileXXXXFormat.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
