[
https://issues.apache.org/jira/browse/MAPREDUCE-5228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13670792#comment-13670792
]
Zhijie Shen commented on MAPREDUCE-5228:
----------------------------------------
Some more comments:
1. FileInputFormat_Counter.properties and FileOutputFormat_Counter.properties
of *mapreduce.lib.input/output* are missing.
2. The following and its analog asserts seem to be unnecessary, because you
have assert that it equals a non-zero number afterwards.
{code}
+ assertTrue(counter.findCounter(FileInputFormat.Counter.BYTES_READ)
+ .getValue() != 0);
{code}
> Enum Counter is removed from FileInputFormat and FileOutputFormat of both
> mapred and mapreduce
> ----------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-5228
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5228
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Reporter: Zhijie Shen
> Assignee: Mayank Bansal
> Attachments: MAPREDUCE-5228-trunk-1.patch,
> MAPREDUCE-5228-trunk-2.patch, MAPREDUCE-5228-trunk-3.patch,
> MAPREDUCE-5228-trunk-4.patch, MAPREDUCE-5228-trunk-5.patch
>
>
> The enum was used by findCounter(Enum key) to find a specific counter object.
> Now it seems to be replaced by FileInputFormatCounter and
> FileOutputFormatCounter. Now the enum seems to be only used internally, but
> not sure whether it will be used externally when users extend FileXXXXFormat.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
