[
https://issues.apache.org/jira/browse/MAPREDUCE-5304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13676530#comment-13676530
]
Zhijie Shen commented on MAPREDUCE-5304:
----------------------------------------
The patch looks almost good.
{code}
+ public boolean killTask(final TaskAttemptID taskId,
+ final boolean shouldFail) throws IOException {
{code}
It seems that killTask(taskId, false) -> killTask(taskId), while
killTask(taskId, true) -> failTask(taskId). However, the method name is a bit
confusing as it is the same as void killTask(TaskId). Users may think these two
methods are equivalent.
How about changing it to boolean killOrFailTask(taskId, mode)? Or separating it
into two: boolean killTask(TaskId, dummyParam) and boolean failTask(TaskId,
dummyParam)?
One addition question. Have we reached an agreement on fixing binary
compatibility to MR1 of *mapreduce* API at the cost of binary incompatibility
to 0.23?
> mapreduce.Job killTask/failTask/getTaskCompletionEvents methods have
> incompatible signature changes
> ---------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-5304
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5304
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 2.0.4-alpha
> Reporter: Alejandro Abdelnur
> Assignee: Karthik Kambatla
> Priority: Blocker
> Attachments: mr-5304-1.patch
>
>
> Pointed out by [~zjshen] in MAPREDUCE-4942.
> In {{o.a.h.mapreduce.Job}} class, the following changed from Hadoop 1 to
> Hadoop 2.
> boolean failTask(TaskAttemptID): Change in return type from void to boolean.
> boolean killTask(TaskAttemptID): Change in return type from void to boolean.
> TaskCompletionEvent[] getTaskCompletionEvents(int): Change in return type
> from org.apache.hadoop.mapred.TaskCompletionEvent[] to
> org.apache.hadoop.mapreduce.TaskCompletionEvent[].
> Using same rational as in other JIRAs, we should fix this to ensure Hadoop 1
> to Hadoop 2 source compatibility (taking 0.23.x releases as a casualty as
> there is not right way for everybody because we screwed up :( ). Flagging it
> as incompatible change because of 0.23.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
