[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13676590#comment-13676590
 ] 

Zhijie Shen commented on MAPREDUCE-5304:
----------------------------------------

bq. I can change the name if you insist; otherwise, I ll leave it consistent 
with ClientProtocol. What do you think?

Not steadfast:-) But just image that 0.23 users need to modify their code 
accordingly. They find they have boolean killTask(TaskID, boolean) to replace 
boolean killTask(TaskID), but they can't found boolean failTask(TaskID, 
boolean) to replace boolean failTask(TaskID)
                
> mapreduce.Job killTask/failTask/getTaskCompletionEvents methods have 
> incompatible signature changes
> ---------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5304
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5304
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>    Affects Versions: 2.0.4-alpha
>            Reporter: Alejandro Abdelnur
>            Assignee: Karthik Kambatla
>            Priority: Blocker
>         Attachments: mr-5304-1.patch
>
>
> Pointed out by [~zjshen] in MAPREDUCE-4942.
> In {{o.a.h.mapreduce.Job}} class, the following changed from Hadoop 1 to 
> Hadoop 2.
> boolean failTask(TaskAttemptID): Change in return type from void to boolean.
> boolean killTask(TaskAttemptID): Change in return type from void to boolean.
> TaskCompletionEvent[] getTaskCompletionEvents(int): Change in return type 
> from org.apache.hadoop.mapred.TaskCompletionEvent[] to 
> org.apache.hadoop.mapreduce.TaskCompletionEvent[].
> Using same rational as in other JIRAs, we should fix this to ensure Hadoop 1 
> to Hadoop 2 source compatibility (taking 0.23.x releases as a casualty as 
> there is not right way for everybody because we screwed up :( ). Flagging it 
> as incompatible change because of 0.23.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to