[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13682594#comment-13682594
 ] 

Jason Lowe commented on MAPREDUCE-5311:
---------------------------------------

I like the idea of a memory-millis counter that uses the granted container size 
to remove the need to know how it was rounded to that value.

However I'm not sure it's best to have slot-millis suddenly start returning 
something that isn't slot-millis.  That could throw off calculations from 
downstream tools that assume a particular slot size (e.g.: min-allocation from 
today's setup).  Probably better to simply not provide slot-millis when it 
cannot be calculated and supply memory-millis as an alternative.
                
> Remove slot millis computation logic and deprecate counter constants
> --------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5311
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5311
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: applicationmaster
>    Affects Versions: 2.0.4-alpha
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>         Attachments: MAPREDUCE-5311.patch
>
>
> Per discussion in MAPREDUCE-5310 and comments in the code we should remove 
> all the related logic and just leave the counter constant for backwards 
> compatibility and deprecate the counter constants.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to