[
https://issues.apache.org/jira/browse/MAPREDUCE-5221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13687157#comment-13687157
]
Karthik Kambatla commented on MAPREDUCE-5221:
---------------------------------------------
Just saw the patch and went through the surrounding code.
Quick question/thought: I see that the ReduceTask fetches the combiner class
via conf.getCombinerClass(). Just like we decide between old and new reducers
as in the snippet below, will it be simpler to get the combiner class (and
create the combine collector) based on {{useNewApi}} also?
{code}
if (useNewApi) {
runNewReducer(job, umbilical, reporter, rIter, comparator,
keyClass, valueClass);
} else {
runOldReducer(job, umbilical, reporter, rIter, comparator,
keyClass, valueClass);
}
{code}
> Reduce side Combiner is not used when using the new API
> -------------------------------------------------------
>
> Key: MAPREDUCE-5221
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5221
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 2.0.4-alpha
> Reporter: Siddharth Seth
> Assignee: Tsuyoshi OZAWA
> Attachments: MAPREDUCE-5221.1.patch, MAPREDUCE-5221.2.patch,
> MAPREDUCE-5221.3.patch, MAPREDUCE-5221.4.patch
>
>
> If a combiner is specified using o.a.h.mapreduce.Job.setCombinerClass - this
> will silently ignored on the reduce side since the reduce side usage is only
> aware of the old api combiner.
> This doesn't fail the job - since the new combiner key does not deprecate the
> old key.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
