[ https://issues.apache.org/jira/browse/MAPREDUCE-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14058278#comment-14058278 ]
Hadoop QA commented on MAPREDUCE-5956: -------------------------------------- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12655133/MR-5956.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 4 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4726//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4726//console This message is automatically generated. > MapReduce AM should not use maxAttempts to determine if this is the last retry > ------------------------------------------------------------------------------ > > Key: MAPREDUCE-5956 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5956 > Project: Hadoop Map/Reduce > Issue Type: Sub-task > Components: applicationmaster, mrv2 > Affects Versions: 2.4.0 > Reporter: Vinod Kumar Vavilapalli > Assignee: Wangda Tan > Priority: Blocker > Attachments: MR-5956.patch, MR-5956.patch > > > Found this while reviewing YARN-2074. The problem is that after YARN-2074, we > don't count AM preemption towards AM failures on RM side, but MapReduce AM > itself checks the attempt id against the max-attempt count to determine if > this is the last attempt. > {code} > public void computeIsLastAMRetry() { > isLastAMRetry = appAttemptID.getAttemptId() >= maxAppAttempts; > } > {code} > This causes issues w.r.t deletion of staging directory etc.. -- This message was sent by Atlassian JIRA (v6.2#6252)