[ https://issues.apache.org/jira/browse/MAPREDUCE-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14106414#comment-14106414 ]
Ashwin Shankar commented on MAPREDUCE-5956: ------------------------------------------- [~zjshen], could you please elaborate when and why this fix will lead to undeleted staging dirs ? In such cases, would the job go missing on the history server ? Any other impact ? I'm asking this, because we are backporting this patch into our release. > MapReduce AM should not use maxAttempts to determine if this is the last retry > ------------------------------------------------------------------------------ > > Key: MAPREDUCE-5956 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5956 > Project: Hadoop Map/Reduce > Issue Type: Sub-task > Components: applicationmaster, mrv2 > Affects Versions: 2.4.0 > Reporter: Vinod Kumar Vavilapalli > Assignee: Wangda Tan > Priority: Blocker > Fix For: 2.6.0 > > Attachments: MR-5956.patch, MR-5956.patch > > > Found this while reviewing YARN-2074. The problem is that after YARN-2074, we > don't count AM preemption towards AM failures on RM side, but MapReduce AM > itself checks the attempt id against the max-attempt count to determine if > this is the last attempt. > {code} > public void computeIsLastAMRetry() { > isLastAMRetry = appAttemptID.getAttemptId() >= maxAppAttempts; > } > {code} > This causes issues w.r.t deletion of staging directory etc.. -- This message was sent by Atlassian JIRA (v6.2#6252)