[
https://issues.apache.org/jira/browse/MAPREDUCE-6005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14080476#comment-14080476
]
Binglin Chang commented on MAPREDUCE-6005:
------------------------------------------
Thanks for the review Sean.
bq. I believe we can rename StringUtil::ToString(const void * v, uint32_t len)
to StringUtil::md5BinaryToString(const void * v, uint32_t len), and also make
ToHex(uint8_t v) private or inlined to md5BinaryToString.
I make the function name from ToString to ToHexString, hex means hex format
binary string, which is md5's format, this format is not restricted to md5
only, so I think ToHexString is more suitable. About ToHex, using static prefix
makes this method private, thats why I add static.
bq. There is another leak at Merge
What do you mean? I already add delete in the code you specified. Do we need to
adding comments only?
> native-task: fix some valgrind errors
> --------------------------------------
>
> Key: MAPREDUCE-6005
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6005
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: task
> Reporter: Binglin Chang
> Assignee: Binglin Chang
> Attachments: MAPREDUCE-6005.v1.patch, MAPREDUCE-6005.v2.patch
>
>
> Running test with valgrind shows there are some bugs, this jira try to fix
> them.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
