[ 
https://issues.apache.org/jira/browse/MAPREDUCE-6005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14080500#comment-14080500
 ] 

Sean Zhong commented on MAPREDUCE-6005:
---------------------------------------

Hi Binling,

About the leak, at src / main / native / src / lib / Merge.cc, there is a 
similar mem leak, you only fixed the leak in PartitionBucketIterator.cc in 
patch 
https://issues.apache.org/jira/secure/attachment/12658416/MAPREDUCE-6005.v2.patch

About toHexString, the name is good. However, maybe better use 
snsprintf(buf_ptr, "%02X", ...)

for (i = 0; i < size; i++)
{
    buf_ptr += snsprintf(buf_ptr, "%02X", buf[i]);
}

> native-task: fix some valgrind errors 
> --------------------------------------
>
>                 Key: MAPREDUCE-6005
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6005
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: task
>            Reporter: Binglin Chang
>            Assignee: Binglin Chang
>         Attachments: MAPREDUCE-6005.v1.patch, MAPREDUCE-6005.v2.patch
>
>
> Running test with valgrind shows there are some bugs, this jira try to fix 
> them.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to