[jira] [Commented] (MAPREDUCE-6204) TestJobCounters should use new properties instead JobConf.MAPRED_TASK_JAVA_OPTS

[Tsuyoshi OZAWA (JIRA)]

    [ 
https://issues.apache.org/jira/browse/MAPREDUCE-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256900#comment-14256900
 ] 

Tsuyoshi OZAWA commented on MAPREDUCE-6204:
-------------------------------------------

I checked MapReduceChildJVM#getChildJavaOpts as Gera mentioned. The method 
includes following code:

{code}
    if (isMapTask) {
      userClasspath = 
          jobConf.get(
              JobConf.MAPRED_MAP_TASK_JAVA_OPTS, 
              jobConf.get(
                  JobConf.MAPRED_TASK_JAVA_OPTS, 
                  JobConf.DEFAULT_MAPRED_TASK_JAVA_OPTS)
          );
     ...
    } else {
      userClasspath =
          jobConf.get(
              JobConf.MAPRED_REDUCE_TASK_JAVA_OPTS, 
              jobConf.get(
                  JobConf.MAPRED_TASK_JAVA_OPTS,
                  JobConf.DEFAULT_MAPRED_TASK_JAVA_OPTS)
              );
       ...
    }
{code}

It means that MAPRED_TASK_JAVA_OPTS is used instead of 
MAPRED_MAP_TASK_JAVA_OPTS and MAPRED_REDUCE_TASK_JAVA_OPTS if 
MAPRED_TASK_JAVA_OPTS is set. 

{quote}
MAPRED_TASK_JAVA_OPTS=-Xms32m -Xmx1G
MAPRED_MAP_TASK_JAVA_OPTS=null
MAPRED_REDUCE_TASK_JAVA_OPTS=null
{quote}

This looks correct behavior since MapReduceChildJVM#getChildJavaOpts just gets 
the value of MAPRED_TASK_JAVA_OPTS instead of MAPRED_MAP_TASK_JAVA_OPTS and 
MAPRED_REDUCE_TASK_JAVA_OPTS. I think the patch doesn't fix the problem. What 
do you think? How about making MAPRED_TASK_JAVA_OPTS larger heap size?

> TestJobCounters should use new properties instead 
> JobConf.MAPRED_TASK_JAVA_OPTS
> -------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-6204
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6204
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: test
>    Affects Versions: 2.6.0
>            Reporter: sam liu
>            Assignee: sam liu
>            Priority: Minor
>         Attachments: MAPREDUCE-6204-1.patch, MAPREDUCE-6204.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)