[ 
https://issues.apache.org/jira/browse/MAPREDUCE-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257920#comment-14257920
 ] 

sam liu commented on MAPREDUCE-6204:
------------------------------------

Tsuyoshi,

Yes, you are correct and the two properties won't be updated. 

I did a test:
1. In TestTaskAttemptContainerRequest.java, I added 
'jobConf.set(JobConf.MAPRED_TASK_JAVA_OPTS, "-Xms32m -Xmx1G")'
2. Then I found the command args created by 'ContainerLaunchContext launchCtx = 
    TaskAttemptImpl.createContainerLaunchContext...' likes:
=$JAVA_HOME/bin/java -Djava.net.preferIPv4Stack=true 
-Dhadoop.metrics.log.level=WARN  -Xms32m -Xmx1G -Djava.io.tmpdir=$PWD/tmp 
-Dlog4j.configuration=container-log4j.properties 
-Dyarn.app.container.log.dir=<LOG_DIR> -Dyarn.app.container.log.filesize=0 
-Dhadoop.root.logger=INFO,CLA org.apache.hadoop.mapred.YarnChild 127.0.0.1 0 
attempt_1_0001_m_000001_1 0 1><LOG_DIR>/stdout 2><LOG_DIR>/stderr

Please mention that only a commn heap setting "-Xms32m -Xmx1G" is added into 
the command args, but the two properties(MAPRED_MAP_TASK_JAVA_OPTS and 
MAPRED_REDUCE_TASK_JAVA_OPTS) were not updated as expected. 

So I think it's still necessary to update MAPRED_MAP_TASK_JAVA_OPTS and 
MAPRED_REDUCE_TASK_JAVA_OPTS values in TestJobCounters, as that test could pass 
on PPC64 only with such updates.


> TestJobCounters should use new properties instead 
> JobConf.MAPRED_TASK_JAVA_OPTS
> -------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-6204
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6204
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: test
>    Affects Versions: 2.6.0
>            Reporter: sam liu
>            Assignee: sam liu
>            Priority: Minor
>         Attachments: MAPREDUCE-6204-1.patch, MAPREDUCE-6204.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to