[
https://issues.apache.org/jira/browse/MAPREDUCE-6234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14308424#comment-14308424
]
Tsuyoshi OZAWA commented on MAPREDUCE-6234:
-------------------------------------------
[~iwasakims] thank you for taking this JIRA. Currently, -1 for this fix.
I think we should fix test side to follow default configuration since the
assertion only check whether check if the high ram properties are not set.
{code}
// check if the high ram properties are not set
assertEquals(expectedMapMB,
simulatedConf.getLong(MRJobConfig.MAP_MEMORY_MB,
MRJobConfig.DEFAULT_MAP_MEMORY_MB));
assertEquals(expectedReduceMB,
simulatedConf.getLong(MRJobConfig.REDUCE_MEMORY_MB,
MRJobConfig.DEFAULT_MAP_MEMORY_MB));
{code}
We should also rethink what we should test in TestHighRamJob - it refers
JT_MAX_MAPMEMORY_MB or some old configurations. Do we really need this tests?
> MRJobConfig.DEFAULT_*_MEMORY_MB should be consistent with mapred-default.xml
> ----------------------------------------------------------------------------
>
> Key: MAPREDUCE-6234
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6234
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/gridmix, mrv2
> Reporter: Masatake Iwasaki
> Assignee: Masatake Iwasaki
> Attachments: MAPREDUCE-6234.001.patch
>
>
> TestHighRamJob fails by this.
> {code}
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.hadoop.mapred.gridmix.TestHighRamJob
> Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.162 sec <<<
> FAILURE! - in org.apache.hadoop.mapred.gridmix.TestHighRamJob
> testHighRamFeatureEmulation(org.apache.hadoop.mapred.gridmix.TestHighRamJob)
> Time elapsed: 1.102 sec <<< FAILURE!
> java.lang.AssertionError: expected:<1024> but was:<-1>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:743)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at org.junit.Assert.assertEquals(Assert.java:555)
> at org.junit.Assert.assertEquals(Assert.java:542)
> at
> org.apache.hadoop.mapred.gridmix.TestHighRamJob.testHighRamConfig(TestHighRamJob.java:98)
> at
> org.apache.hadoop.mapred.gridmix.TestHighRamJob.testHighRamFeatureEmulation(TestHighRamJob.java:117)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
