[ 
https://issues.apache.org/jira/browse/MAPREDUCE-6234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309665#comment-14309665
 ] 

Masatake Iwasaki commented on MAPREDUCE-6234:
---------------------------------------------

[~varun_saxena], some tests need not "effective default value" but value 
literally set in conf. The name DEFAULT_MAP_MEMORY_MB implies the default value 
of "mapreduce.map.memory.mb". 1024 is the value defermined from 
"mapreduce.map.memory.mb" *and* "mapreduce.map.java.opts". If we need the 1024 
in some constants, it should not be named as DEFAULT_MAP_MEMORY_MB. The .002 
patch addresses this.

> MRJobConfig.DEFAULT_*_MEMORY_MB should be consistent with mapred-default.xml
> ----------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-6234
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6234
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: contrib/gridmix, mrv2
>            Reporter: Masatake Iwasaki
>            Assignee: Masatake Iwasaki
>         Attachments: MAPREDUCE-6234.001.patch, MAPREDUCE-6234.002.patch
>
>
> TestHighRamJob fails by this.
> {code}
> -------------------------------------------------------
>  T E S T S
> -------------------------------------------------------
> Running org.apache.hadoop.mapred.gridmix.TestHighRamJob
> Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.162 sec <<< 
> FAILURE! - in org.apache.hadoop.mapred.gridmix.TestHighRamJob
> testHighRamFeatureEmulation(org.apache.hadoop.mapred.gridmix.TestHighRamJob)  
> Time elapsed: 1.102 sec  <<< FAILURE!
> java.lang.AssertionError: expected:<1024> but was:<-1>
>       at org.junit.Assert.fail(Assert.java:88)
>       at org.junit.Assert.failNotEquals(Assert.java:743)
>       at org.junit.Assert.assertEquals(Assert.java:118)
>       at org.junit.Assert.assertEquals(Assert.java:555)
>       at org.junit.Assert.assertEquals(Assert.java:542)
>       at 
> org.apache.hadoop.mapred.gridmix.TestHighRamJob.testHighRamConfig(TestHighRamJob.java:98)
>       at 
> org.apache.hadoop.mapred.gridmix.TestHighRamJob.testHighRamFeatureEmulation(TestHighRamJob.java:117)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to