[
https://issues.apache.org/jira/browse/MAPREDUCE-6339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516448#comment-14516448
]
Devaraj K commented on MAPREDUCE-6339:
--------------------------------------
[~zxu], Can you look into this checkstyle issue in the patch?
{code:xml}
-1 checkstyle 3m 58s The applied patch generated 1 additional
checkstyle issues.
{code}
> Job history file is not flushed correctly because isTimerActive flag is not
> set true when flushTimerTask is scheduled.
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-6339
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6339
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 2.7.0
> Reporter: zhihai xu
> Assignee: zhihai xu
> Priority: Critical
> Attachments: MAPREDUCE-6339.000.patch
>
>
> Job history file is not flushed correctly because isTimerActive flag is not
> set true when flushTimerTask is scheduled.
> It looks like we should set isTimerActive to true when flushTimerTask is
> scheduled. Otherwise if a new qualified event comes before the current flush
> timer is expired, flushTimerTask will be canceled and rescheduled.
> Also I didn't find any code which set isTimerActive flag to true, So
> isTimerActive is useless in current code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
