[
https://issues.apache.org/jira/browse/MAPREDUCE-6339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518708#comment-14518708
]
zhihai xu commented on MAPREDUCE-6339:
--------------------------------------
The last Jenkins run didn't have checkstyle issue. The only difference between
these two patches is an import statement:
{code}
import com.google.common.annotations.VisibleForTesting;
{code}
It looks like the import statement causes this checkstyle issue. But this
import statement looks good to me.
Don't know why the checkstyle script report this issue. So it looks like a
script issue.
> Job history file is not flushed correctly because isTimerActive flag is not
> set true when flushTimerTask is scheduled.
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-6339
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6339
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 2.7.0
> Reporter: zhihai xu
> Assignee: zhihai xu
> Priority: Critical
> Attachments: MAPREDUCE-6339.000.patch, MAPREDUCE-6339.test1.patch
>
>
> Job history file is not flushed correctly because isTimerActive flag is not
> set true when flushTimerTask is scheduled.
> It looks like we should set isTimerActive to true when flushTimerTask is
> scheduled. Otherwise if a new qualified event comes before the current flush
> timer is expired, flushTimerTask will be canceled and rescheduled.
> Also I didn't find any code which set isTimerActive flag to true, So
> isTimerActive is useless in current code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
