[ https://issues.apache.org/jira/browse/MAPREDUCE-6339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14519891#comment-14519891 ]
zhihai xu commented on MAPREDUCE-6339: -------------------------------------- The two test patches MAPREDUCE-6339.test.patch and MAPREDUCE-6339.test1.patch is to prove this is most likely a checkstyle script issue. The only difference between MAPREDUCE-6339.test.patch and MAPREDUCE-6339.test1.patch is an import statement, which doesn't look like an issue for me. The original patch MAPREDUCE-6339.000.patch is the one for review and commit > Job history file is not flushed correctly because isTimerActive flag is not > set true when flushTimerTask is scheduled. > ---------------------------------------------------------------------------------------------------------------------- > > Key: MAPREDUCE-6339 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6339 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv2 > Affects Versions: 2.7.0 > Reporter: zhihai xu > Assignee: zhihai xu > Priority: Critical > Attachments: MAPREDUCE-6339.000.patch, MAPREDUCE-6339.test.patch, > MAPREDUCE-6339.test1.patch > > > Job history file is not flushed correctly because isTimerActive flag is not > set true when flushTimerTask is scheduled. > It looks like we should set isTimerActive to true when flushTimerTask is > scheduled. Otherwise if a new qualified event comes before the current flush > timer is expired, flushTimerTask will be canceled and rescheduled. > Also I didn't find any code which set isTimerActive flag to true, So > isTimerActive is useless in current code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)