[jira] [Commented] (MAPREDUCE-6174) Combine common stream code into parent class for InMemoryMapOutput and OnDiskMapOutput.

[Gera Shegalov (JIRA)]

    [ 
https://issues.apache.org/jira/browse/MAPREDUCE-6174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14533937#comment-14533937
 ] 

Gera Shegalov commented on MAPREDUCE-6174:
------------------------------------------

Hi [~eepayne], thank you for working on the patch. We can check what checkstyle 
problems a patch introduced as follows.

Run 
{code}
$ mvn clean checkstyle:checkstyle-aggregate
{code}
before and after applying the patch.

Save the resulting {{target/test/checkstyle-errors.xml}} after each run. Then 
we can diff both files. The diff will be concise if we get rid of line numbers.

{code}
]$ diff <(cat ~/checkstyle-errors-trunk.xml | sed 's/line=\"[0-9]*\"//g') <(cat 
./target/test/checkstyle-errors.xml | sed 's/line=\"[0-9]*\"//g') 
46768a46769,46772
> <file 
> name="/Users/gshegalov/workspace/hadoop-common/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/task/reduce/IFileWrappedMapOutput.java">
> <error  column="40" severity="error" message="&apos;conf&apos; hides a 
> field." 
> source="com.puppycrawl.tools.checkstyle.checks.coding.HiddenFieldCheck"/>
> <error  column="51" severity="error" message="&apos;merger&apos; hides a 
> field." 
> source="com.puppycrawl.tools.checkstyle.checks.coding.HiddenFieldCheck"/>
> </file>
46770d46773
< <error  severity="error" message="&apos;new&apos; have incorrect indentation 
level 6, expected level should be 8." 
source="com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck"/>
46911d46913
< <error  severity="error" message="Line is longer than 80 characters (found 
109)." source="com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck"/>
{code}

> Combine common stream code into parent class for InMemoryMapOutput and 
> OnDiskMapOutput.
> ---------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-6174
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6174
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: mrv2
>    Affects Versions: 3.0.0, 2.6.0
>            Reporter: Eric Payne
>            Assignee: Eric Payne
>              Labels: BB2015-05-TBR
>         Attachments: MAPREDUCE-6174.002.patch, MAPREDUCE-6174.003.patch, 
> MAPREDUCE-6174.v1.txt
>
>
> Per MAPREDUCE-6166, both InMemoryMapOutput and OnDiskMapOutput will be doing 
> similar things with regards to IFile streams.
> In order to make it explicit that InMemoryMapOutput and OnDiskMapOutput are 
> different from 3rd-party implementations, this JIRA will make them subclass a 
> common class (see 
> https://issues.apache.org/jira/browse/MAPREDUCE-6166?focusedCommentId=14223368&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14223368)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)