[
https://issues.apache.org/jira/browse/MAPREDUCE-6174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14567812#comment-14567812
]
Gera Shegalov commented on MAPREDUCE-6174:
------------------------------------------
Hi [~eepayne], thanks for 006. Agreed regarding checkstyle.
I am sorry, I have one remaining tiny nit before committing. The second
deprecated constructor should also delegate for clarity:
{code}
@Deprecated
@VisibleForTesting
OnDiskMapOutput(TaskAttemptID mapId, TaskAttemptID reduceId,
MergeManagerImpl<K,V> merger, long size,
JobConf conf,
MapOutputFile mapOutputFile,
int fetcher, boolean primaryMapOutput,
FileSystem fs, Path outputPath) throws IOException {
this(mapId, merger, size, conf, fetcher, primaryMapOutput, fs, outputPath);
}
{code}
> Combine common stream code into parent class for InMemoryMapOutput and
> OnDiskMapOutput.
> ---------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-6174
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6174
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: mrv2
> Affects Versions: 3.0.0, 2.6.0
> Reporter: Eric Payne
> Assignee: Eric Payne
> Labels: BB2015-05-RFC
> Attachments: MAPREDUCE-6174.002.patch, MAPREDUCE-6174.003.patch,
> MAPREDUCE-6174.004.patch, MAPREDUCE-6174.005.patch, MAPREDUCE-6174.006.patch,
> MAPREDUCE-6174.v1.txt
>
>
> Per MAPREDUCE-6166, both InMemoryMapOutput and OnDiskMapOutput will be doing
> similar things with regards to IFile streams.
> In order to make it explicit that InMemoryMapOutput and OnDiskMapOutput are
> different from 3rd-party implementations, this JIRA will make them subclass a
> common class (see
> https://issues.apache.org/jira/browse/MAPREDUCE-6166?focusedCommentId=14223368&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14223368)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
