[
https://issues.apache.org/jira/browse/MAPREDUCE-6400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14590174#comment-14590174
]
Akira AJISAKA commented on MAPREDUCE-6400:
------------------------------------------
Thanks [~jira.shegalov] and [~brahmareddy] for creating the patch. In Gera's
patch, if {{inOwner}} is set to false, we cannot close the wrapped stream when
an exception occurs. Therefore I prefer Brahma's one.
Some comments for Brahma's patch.
1. Would you please catch {{IOException}} in {{IFileWrappedMapOutput#shuffle}}?
In the catch clause, we should close the wrapped stream and re-throw the
exception.
2. Would you remove unused imports from TestReduceFetchFromPartialMem.java and
TestFetcher.java?
> TestReduceFetchFromPartialMem fails
> -----------------------------------
>
> Key: MAPREDUCE-6400
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6400
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: task
> Affects Versions: 2.8.0
> Reporter: Akira AJISAKA
> Assignee: Gera Shegalov
> Priority: Blocker
> Attachments: MAPREDUCE-6400.001.patch, MAPREDUCE-6400.patch
>
>
> TestReduceFetchFromPartialMem fails.
> {noformat}
> Running org.apache.hadoop.mapred.TestReduceFetchFromPartialMem
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 132.978 sec
> <<< FAILURE! - in org.apache.hadoop.mapred.TestReduceFetchFromPartialMem
> testReduceFromPartialMem(org.apache.hadoop.mapred.TestReduceFetchFromPartialMem)
> Time elapsed: 69.214 sec <<< ERROR!
> java.io.IOException: Job failed!
> at org.apache.hadoop.mapred.JobClient.runJob(JobClient.java:867)
> at
> org.apache.hadoop.mapred.TestReduceFetchFromPartialMem.runJob(TestReduceFetchFromPartialMem.java:300)
> at
> org.apache.hadoop.mapred.TestReduceFetchFromPartialMem.testReduceFromPartialMem(TestReduceFetchFromPartialMem.java:93)
> Results :
> Tests in error:
> TestReduceFetchFromPartialMem.testReduceFromPartialMem:93->runJob:300 ยป IO
> Job...
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
