[ 
https://issues.apache.org/jira/browse/MAPREDUCE-6400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595999#comment-14595999
 ] 

Jason Lowe commented on MAPREDUCE-6400:
---------------------------------------

bq.  do you mean iFin in the 003 patch should be changed to the wrapped stream?

Actually no, I'm not a big fan of that approach either.  Again, it seems weird 
to me that we're closing the stream only sometimes, and that sometimes is only 
when something fails.  IMHO the code that is fielding the error and calling 
abort should be the one closing the stream, as this is likely the one that 
passed the stream into the map output in the first place.  As Gera mentioned 
above, it's simplest if the code that opens the stream closes the stream.  It 
gets confusing when the ownership is conditional like this.


> TestReduceFetchFromPartialMem fails
> -----------------------------------
>
>                 Key: MAPREDUCE-6400
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6400
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: task
>    Affects Versions: 2.8.0
>            Reporter: Akira AJISAKA
>            Assignee: Brahma Reddy Battula
>            Priority: Blocker
>         Attachments: MAPREDUCE-6400-002.patch, MAPREDUCE-6400.001.patch, 
> MAPREDUCE-6400.003.patch, MAPREDUCE-6400.004.patch, MAPREDUCE-6400.patch
>
>
> TestReduceFetchFromPartialMem fails.
> {noformat}
> Running org.apache.hadoop.mapred.TestReduceFetchFromPartialMem
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 132.978 sec 
> <<< FAILURE! - in org.apache.hadoop.mapred.TestReduceFetchFromPartialMem
> testReduceFromPartialMem(org.apache.hadoop.mapred.TestReduceFetchFromPartialMem)
>   Time elapsed: 69.214 sec  <<< ERROR!
> java.io.IOException: Job failed!
>       at org.apache.hadoop.mapred.JobClient.runJob(JobClient.java:867)
>       at 
> org.apache.hadoop.mapred.TestReduceFetchFromPartialMem.runJob(TestReduceFetchFromPartialMem.java:300)
>       at 
> org.apache.hadoop.mapred.TestReduceFetchFromPartialMem.testReduceFromPartialMem(TestReduceFetchFromPartialMem.java:93)
> Results :
> Tests in error: 
>   TestReduceFetchFromPartialMem.testReduceFromPartialMem:93->runJob:300 ยป IO 
> Job...
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to