[
https://issues.apache.org/jira/browse/MAPREDUCE-6384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14600136#comment-14600136
]
Jason Lowe commented on MAPREDUCE-6384:
---------------------------------------
Thanks for the patch [~lichangleo]!
Patch looks good overall, mostly just nits:
- "Too Many fetch failures." s/b "Too many fetch failures."
- "Reported by" s/b "Last failure reported by"
- Why are we declaring a hostname variable outside of the one block where it's
needed? Would be better if it was just "String hostname = ..."
- What is the significance of "sudoHost"? Ideally the test should be using
different hostnames per reducers and verifying the correct hostname is returned
for the reducer identified.
- testFetchFailureDiagnos is basically a copy of
testFetchFailureMultipleReduces. Rather than duplicate all the code and pay
for the full runtime of almost the same test, it'd be cheaper to just add the
one assert on the diagnostic message to testFetchFailureMultipleReduces.
> add the last reporting reducer host info and attempt id on the map error
> message due to too many fetch failure
> --------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-6384
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6384
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Chang Li
> Assignee: Chang Li
> Attachments: MAPREDUCE-6384.2.patch, MAPREDUCE-6384.3.patch,
> MAPREDUCE-6384.4.2.patch, MAPREDUCE-6384.4.patch, MAPREDUCE-6384.5.patch,
> MAPREDUCE-6384.6.patch, MAPREDUCE-6384.7.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
